🐛 Update ClusterCertificateRotated to false if the signer name is invalid

[zhujian7]

Summary

Update ClusterCertificateRotated to false if the signer name is invalid, i.e:

  - lastTransitionTime: "2024-06-07T08:11:10Z"
    message: 'Failed to create CSR CertificateSigningRequest.certificates.k8s.io "addon-cluster1-hello-template-rlmsp"
      is invalid: spec.signerName: Invalid value: "xxx-addon": must be a fully qualified
      domain and path of the form ''example.com/signer-name'''
    reason: ClientCertificateUpdateFailed
    status: "False"
    type: ClusterCertificateRotated

Related issue(s)

Fixes ##382

[zhujian7]

/cc @qiujian16 @skeeey

[zhujian7]

/cc @elgnay

[codecov]

Codecov Report

Attention: Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.

Project coverage is 62.18%. Comparing base (9b36e11) to head (8bb0a70).

Files	Patch %	Lines
pkg/registration/clientcert/cert_controller.go	28.57%	11 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   62.21%   62.18%   -0.04%     
==========================================
  Files         141      141              
  Lines       11769    11780      +11     
==========================================
+ Hits         7322     7325       +3     
- Misses       3675     3683       +8     
  Partials      772      772              

Flag	Coverage Δ
unit	62.18% <28.57%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[elgnay]

/lgtm

[qiujian16]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/registration/OWNERS [qiujian16]
• test/OWNERS [qiujian16,zhujian7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment