Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix issue that pull secret and ns are synced labels when enable-sync-labels is disabled #511

Conversation

zhiweiyin318
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from xuezhaojun and zhujian7 June 12, 2024 07:53
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.11%. Comparing base (196bf40) to head (28a6179).
Report is 2 commits behind head on main.

Files Patch % Lines
...usterletcontroller/klusterlet_managed_reconcile.go 66.66% 0 Missing and 3 partials ⚠️
...usterletcontroller/klusterlet_runtime_reconcile.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   62.15%   62.11%   -0.04%     
==========================================
  Files         141      141              
  Lines       11780    11750      -30     
==========================================
- Hits         7322     7299      -23     
+ Misses       3684     3678       -6     
+ Partials      774      773       -1     
Flag Coverage Δ
unit 62.11% <80.76%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhiweiyin318
Copy link
Member Author

/assign @qiujian16

…labels is disabled

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
@dongbeiqing91
Copy link
Contributor

lgtm

@qiujian16
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 287a6fb into open-cluster-management-io:main Jun 13, 2024
14 checks passed
@zhiweiyin318 zhiweiyin318 deleted the fix-label-flag branch June 13, 2024 03:29
zhiweiyin318 added a commit to zhiweiyin318/ocm that referenced this pull request Jun 13, 2024
…labels is disabled (open-cluster-management-io#511)

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
zhiweiyin318 added a commit to zhiweiyin318/ocm that referenced this pull request Jun 13, 2024
…labels is disabled (open-cluster-management-io#511)

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
openshift-merge-bot bot pushed a commit that referenced this pull request Jun 13, 2024
* sync labels from klusterlet to all agent resources (#475)

Signed-off-by: Zhiwei Yin <zyin@redhat.com>

* add enable-sync-labels flag to klusterlet operator (#505)

Signed-off-by: Zhiwei Yin <zyin@redhat.com>

* fix issue that pull secret and ns are synced labels when enable-sync-labels is disabled (#511)

Signed-off-by: Zhiwei Yin <zyin@redhat.com>

---------

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants