-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix issue that pull secret and ns are synced labels when enable-sync-labels is disabled #511
🐛 fix issue that pull secret and ns are synced labels when enable-sync-labels is disabled #511
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
- Coverage 62.15% 62.11% -0.04%
==========================================
Files 141 141
Lines 11780 11750 -30
==========================================
- Hits 7322 7299 -23
+ Misses 3684 3678 -6
+ Partials 774 773 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/assign @qiujian16 |
…labels is disabled Signed-off-by: Zhiwei Yin <zyin@redhat.com>
8708108
to
28a6179
Compare
lgtm |
/lgtm |
287a6fb
into
open-cluster-management-io:main
…labels is disabled (open-cluster-management-io#511) Signed-off-by: Zhiwei Yin <zyin@redhat.com>
…labels is disabled (open-cluster-management-io#511) Signed-off-by: Zhiwei Yin <zyin@redhat.com>
* sync labels from klusterlet to all agent resources (#475) Signed-off-by: Zhiwei Yin <zyin@redhat.com> * add enable-sync-labels flag to klusterlet operator (#505) Signed-off-by: Zhiwei Yin <zyin@redhat.com> * fix issue that pull secret and ns are synced labels when enable-sync-labels is disabled (#511) Signed-off-by: Zhiwei Yin <zyin@redhat.com> --------- Signed-off-by: Zhiwei Yin <zyin@redhat.com>
Summary
Related issue(s)
Fixes #