Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 using managed cluster instead of spoke in log msg #512

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

skeeey
Copy link
Member

@skeeey skeeey commented Jun 12, 2024

Summary

using managed cluster instead of spoke in log message

Related issue(s)

Fixes #393

Signed-off-by: Wei Liu <liuweixa@redhat.com>
@openshift-ci openshift-ci bot requested review from elgnay and ldpliu June 12, 2024 07:55
@skeeey
Copy link
Member Author

skeeey commented Jun 12, 2024

/assign @qiujian16

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.10%. Comparing base (8e792c1) to head (4759a5c).

Files Patch % Lines
pkg/registration/clientcert/certificate.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
+ Coverage   62.08%   62.10%   +0.01%     
==========================================
  Files         141      141              
  Lines       11740    11740              
==========================================
+ Hits         7289     7291       +2     
+ Misses       3678     3677       -1     
+ Partials      773      772       -1     
Flag Coverage Δ
unit 62.10% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 12, 2024
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, skeeey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8e5d1a1 into open-cluster-management-io:main Jun 12, 2024
14 checks passed
@skeeey skeeey deleted the msg branch June 12, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We need use managed cluster instead of spoke in all massages or logs
2 participants