Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support daemonSet with AddOnTemplate #521

Conversation

zhujian7
Copy link
Member

Summary

Related issue(s)

#368

Fixes #

@openshift-ci openshift-ci bot requested review from haoqing0110 and ldpliu June 14, 2024 08:13
go.mod Outdated Show resolved Hide resolved
@zhujian7 zhujian7 changed the title Support daemonSet with AddOnTemplate ✨ Support daemonSet with AddOnTemplate Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.14%. Comparing base (c5729ae) to head (62f52dd).

Files Patch % Lines
pkg/addon/templateagent/decorator.go 80.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
+ Coverage   62.12%   62.14%   +0.01%     
==========================================
  Files         141      141              
  Lines       11747    11768      +21     
==========================================
+ Hits         7298     7313      +15     
- Misses       3677     3680       +3     
- Partials      772      775       +3     
Flag Coverage Δ
unit 62.14% <81.81%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7 zhujian7 force-pushed the daemonset-addon-template branch 2 times, most recently from 08de37d to fd7e7f9 Compare June 17, 2024 03:04
@zhujian7
Copy link
Member Author

/cc @qiujian16 @zhiweiyin318

@openshift-ci openshift-ci bot requested review from qiujian16 and zhiweiyin318 June 17, 2024 08:34
@qiujian16
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhiweiyin318
Copy link
Member

/lgtm
/hold

@haoqing0110
Copy link
Member

LGTM

Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7 zhujian7 force-pushed the daemonset-addon-template branch from fd7e7f9 to 62f52dd Compare June 19, 2024 14:33
@openshift-ci openshift-ci bot removed the lgtm label Jun 19, 2024
@zhujian7
Copy link
Member Author

@zhiweiyin318 @haoqing0110 Some conflicts have just been resolved, PTAL.

@haoqing0110
Copy link
Member

/lgtm

@zhujian7
Copy link
Member Author

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 3b2601d into open-cluster-management-io:main Jun 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants