Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fix typo: Rename 'CommoOpts' to 'CommonOpts' #523

Conversation

ohkinozomu
Copy link
Contributor

Summary

Related issue(s)

Fixes #

Signed-off-by: ohkinozomu <nozomunoise@gmail.com>
@openshift-ci openshift-ci bot requested review from jnpacker and qiujian16 June 15, 2024 13:21
@zhujian7
Copy link
Member

/lgtm

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.09%. Comparing base (565af66) to head (521ad0f).

Files Patch % Lines
pkg/common/options/agent.go 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
- Coverage   62.11%   62.09%   -0.02%     
==========================================
  Files         141      141              
  Lines       11744    11744              
==========================================
- Hits         7295     7293       -2     
- Misses       3677     3678       +1     
- Partials      772      773       +1     
Flag Coverage Δ
unit 62.09% <16.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ohkinozomu, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1227b71 into open-cluster-management-io:main Jun 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants