Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 make additional secret data always sensitive #525

Conversation

elgnay
Copy link
Contributor

@elgnay elgnay commented Jun 17, 2024

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from ldpliu and skeeey June 17, 2024 03:55
@elgnay elgnay force-pushed the make-additional-data-sensitive branch from 0f46cc0 to 2b1e5cd Compare June 17, 2024 04:29
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.14%. Comparing base (1227b71) to head (e0cf2b5).
Report is 13 commits behind head on main.

Files Patch % Lines
...egistration/spoke/addon/registration_controller.go 0.00% 5 Missing ⚠️
pkg/registration/spoke/spokeagent.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
+ Coverage   62.11%   62.14%   +0.02%     
==========================================
  Files         141      141              
  Lines       11744    11739       -5     
==========================================
  Hits         7295     7295              
+ Misses       3677     3672       -5     
  Partials      772      772              
Flag Coverage Δ
unit 62.14% <22.22%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elgnay elgnay force-pushed the make-additional-data-sensitive branch from 2b1e5cd to 2b85559 Compare June 17, 2024 08:06
Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elgnay elgnay force-pushed the make-additional-data-sensitive branch from 2b85559 to 4aa49e5 Compare June 18, 2024 03:25
Signed-off-by: Yang Le <yangle@redhat.com>
@elgnay elgnay force-pushed the make-additional-data-sensitive branch from 4aa49e5 to e0cf2b5 Compare June 18, 2024 04:42
@qiujian16
Copy link
Member

/hold
we should merge this after release of 0.14.0

@qiujian16
Copy link
Member

/lgtm

@qiujian16
Copy link
Member

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit a14450a into open-cluster-management-io:main Jun 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants