Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 refactor certrotation controller with sdk-go #526

Conversation

zhiweiyin318
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from elgnay and xuezhaojun June 17, 2024 09:07
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.33%. Comparing base (74f4c92) to head (af3f7d2).
Report is 7 commits behind head on main.

Files Patch % Lines
.../certrotationcontroller/certrotation_controller.go 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
+ Coverage   62.11%   62.33%   +0.21%     
==========================================
  Files         141      138       -3     
  Lines       11744    11583     -161     
==========================================
- Hits         7295     7220      -75     
+ Misses       3677     3597      -80     
+ Partials      772      766       -6     
Flag Coverage Δ
unit 62.33% <94.73%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 84eaf5b into open-cluster-management-io:main Jun 24, 2024
14 checks passed
@zhiweiyin318 zhiweiyin318 deleted the refactor-cert branch June 24, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants