-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add install namespace to built in values #533
🐛 Add install namespace to built in values #533
Conversation
Signed-off-by: zhujian <jiazhu@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
=======================================
Coverage 62.11% 62.12%
=======================================
Files 141 141
Lines 11744 11747 +3
=======================================
+ Hits 7295 7298 +3
Misses 3677 3677
Partials 772 772
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/cc @qiujian16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need to keep the private install namespace value?
@qiujian16 I'm not sure, but I just want to keep the changes as small as possible here. |
OK I think we need to refactor this a bit in the next release. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c5729ae
into
open-cluster-management-io:main
Summary
Add
INSTALL_NAMESPACE
to the built in values if the private value__INSTALL_NAMESPACE
is set.Related issue(s)
Fixes #