Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱Refactor makefile e2e commands. #534

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Jun 19, 2024

Summary

Except for the standard e2e prepare process: test-e2e.

We may also want to customized the process, for example:

# deploy ocm hub on hub1
make deploy-hub KUBECONFIG=/home/runner/.kube/hub1 HUB_KUBECONFIG=/home/runner/.kube/hub1-kubeconfig

# deploy ocm hub on hub2
make deploy-hub KUBECONFIG=/home/runner/.kube/hub2 HUB_KUBECONFIG=/home/runner/.kube/hub2-kubeconfig

# deploy ocm agent on spoke
make deploy-spoke-operator KUBECONFIG=/home/runner/.kube/spoke

run-e2e

The changes intend to make deploy-hub and run-e2e commands more independent, so we can reuse them in different e2e prepare processes.

@openshift-ci openshift-ci bot requested review from zhiweiyin318 and zhujian7 June 19, 2024 08:00
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.12%. Comparing base (565af66) to head (7bc2727).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #534   +/-   ##
=======================================
  Coverage   62.11%   62.12%           
=======================================
  Files         141      141           
  Lines       11744    11747    +3     
=======================================
+ Hits         7295     7298    +3     
  Misses       3677     3677           
  Partials      772      772           
Flag Coverage Δ
unit 62.12% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun
Copy link
Member Author

/assign @qiujian16

@xuezhaojun xuezhaojun force-pushed the simplify-makefile-commands branch from 5c3036a to c6d2630 Compare June 19, 2024 09:49
Signed-off-by: xuezhaojun <zxue@redhat.com>
@xuezhaojun xuezhaojun force-pushed the simplify-makefile-commands branch from c6d2630 to 7bc2727 Compare June 19, 2024 15:26
@xuezhaojun xuezhaojun changed the title 🌱Simplify makefile e2e commands. 🌱Refactor makefile e2e commands. Jun 19, 2024
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 20, 2024
Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 21f3399 into open-cluster-management-io:main Jun 20, 2024
17 checks passed
@xuezhaojun xuezhaojun deleted the simplify-makefile-commands branch August 16, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants