Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Set the first daemonset namespace to registration namespace if no deployments #536

Conversation

zhujian7
Copy link
Member

Summary

Set the first daemonset namespace to the registration namespace if no deployments in the addonTemplate

Related issue(s)

Fixes #

Signed-off-by: zhujian <jiazhu@redhat.com>
Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhujian7
Copy link
Member Author

/hold

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.21%. Comparing base (21f3399) to head (73b5c7a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   62.16%   62.21%   +0.05%     
==========================================
  Files         141      141              
  Lines       11768    11776       +8     
==========================================
+ Hits         7315     7327      +12     
+ Misses       3679     3677       -2     
+ Partials      774      772       -2     
Flag Coverage Δ
unit 62.21% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7
Copy link
Member Author

/unhold
/cc @qiujian16

@qiujian16
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 41197e5 into open-cluster-management-io:main Jun 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants