Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix: should use klog.FromContext instead of log.FromContext #537

Conversation

xuezhaojun
Copy link
Member

Summary

When I was debugging the registraiton issue, found this part of log is not shown. It turns out using the wrong FromContext function.

Signed-off-by: GitHub <noreply@github.com>
@openshift-ci openshift-ci bot requested review from elgnay and ldpliu June 24, 2024 05:54
@xuezhaojun
Copy link
Member Author

/assign @qiujian16

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.21%. Comparing base (b6058f1) to head (118dc05).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/registration/spoke/bootstrapkubeconfigs.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   62.21%   62.21%           
=======================================
  Files         141      141           
  Lines       11776    11776           
=======================================
  Hits         7327     7327           
  Misses       3677     3677           
  Partials      772      772           
Flag Coverage Δ
unit 62.21% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun xuezhaojun closed this Jun 24, 2024
@xuezhaojun xuezhaojun reopened this Jun 24, 2024
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 24, 2024
Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6767167 into open-cluster-management-io:main Jun 24, 2024
23 of 24 checks passed
@xuezhaojun xuezhaojun deleted the fix-should-use-klog branch June 24, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants