-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Explicitly rename and use universal klusterlet/managed cluster. #556
🌱 Explicitly rename and use universal klusterlet/managed cluster. #556
Conversation
352d595
to
09dc962
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
- Coverage 62.41% 62.40% -0.02%
==========================================
Files 177 177
Lines 13857 13857
==========================================
- Hits 8649 8647 -2
- Misses 4339 4340 +1
- Partials 869 870 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
305f7c1
to
a57c3eb
Compare
/assign @qiujian16 |
a57c3eb
to
f04f065
Compare
test/e2e/e2e_suite_test.go
Outdated
) | ||
|
||
const ( | ||
UNIVERSAL_CLUSTERSET = "universal" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this is public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, it shouldn't be.
test/e2e/e2e_suite_test.go
Outdated
// but also pay attention, because the klusterlet is shared, so the developers should not delete the klusterlet. | ||
// And there might be some side effects on other cases if the developers change the klusterlet's spec for their cases. | ||
var ( | ||
universalClusterName string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also define the default value here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we can, updated.
56c65be
to
87e8850
Compare
Signed-off-by: xuezhaojun <zxue@redhat.com>
87e8850
to
4041f05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4b77db8
into
open-cluster-management-io:main
Summary
Cases are using a shared, universal klusterlet/managed cluster, rename the field to expilicitly hight this point.
Also:
ocm/test/e2e/e2e_suite_test.go
Lines 85 to 87 in b3f15c1