🐛 fix: put the update into a eventually to avoid flaky error.

[xuezhaojun]

Summary

Sometimes the update operation need another try.

To avoid errors like the following:

  Event: [hub-managedclustercontroller] NamespaceCreated: Created Namespace/autoapprovaltest-spoke-cluster1 because it was missing 
  [FAILED] in [It] - /home/runner/work/ocm/ocm/test/integration/registration/spokecluster_autoapproval_test.go:134 @ 07/05/24 03:36:20.343
• [FAILED] [0.011 seconds]
Cluster Auto Approval [It] Cluster can be denied by manually after automatically approved
/home/runner/work/ocm/ocm/test/integration/registration/spokecluster_autoapproval_test.go:100

  [FAILED] Unexpected error:
      <*errors.StatusError | 0xc0004cc500>: 
      Operation cannot be fulfilled on managedclusters.cluster.open-cluster-management.io "autoapprovaltest-spoke-cluster1": the object has been modified; please apply your changes to the latest version and try again
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "Operation cannot be fulfilled on managedclusters.cluster.open-cluster-management.io \"autoapprovaltest-spoke-cluster1\": the object has been modified; please apply your changes to the latest version and try again",
              Reason: "Conflict",
              Details: {
                  Name: "autoapprovaltest-spoke-cluster1",
                  Group: "cluster.open-cluster-management.io",
                  Kind: "managedclusters",
                  UID: "",
                  Causes: nil,
                  RetryAfterSeconds: 0,
              },
              Code: 409,
          },
      }
  occurred
  In [It] at: /home/runner/work/ocm/ocm/test/integration/registration/spokecluster_autoapproval_test.go:134 @ 07/05/24 03:36:20.343

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.41%. Comparing base (b3f15c1) to head (e01f5e8).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #557   +/-   ##
=======================================
  Coverage   62.41%   62.41%           
=======================================
  Files         177      177           
  Lines       13857    13857           
=======================================
  Hits         8649     8649           
  Misses       4339     4339           
  Partials      869      869           

Flag	Coverage Δ
unit	62.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[qiujian16]

I do not think it works, you need to also call get in eventually.

[xuezhaojun]

You're right, updated.

[xuezhaojun]

/assign @qiujian16

[qiujian16]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [qiujian16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment