🐛 Fix: hello template e2e error.

[xuezhaojun]

Summary

Recently we got this addon-manager flaky errors very frequently:

  [FAILED] Timed out after 300.000s.
  Expected success, but got an error:
      <*errors.errorString | 0xc000b835c0>: 
      the addon e2e-universal-managedcluster-phbngt/hello-template available condition is not true, [{Progressing True 0 2024-07-05 04:47:53 +0000 UTC Progressing progressing... work is not ready} {RegistrationApplied True 0 2024-07-05 04:47:53 +0000 UTC SetPermissionApplied Registration of the addon agent is configured} {ClusterCertificateRotated False 0 2024-07-05 04:47:53 +0000 UTC ClientCertificateUpdateFailed Failed to rotated client certificate namespaces "open-cluster-management-agent-addon" not found} {ManifestApplied False 0 2024-07-05 04:47:53 +0000 UTC AddonManifestAppliedFailed failed to apply the manifests of addon} {Available False 0 2024-07-05 04:47:53 +0000 UTC WorkNotApplied 3 of 4 resources are not available}]
      {
          s: "the addon e2e-universal-managedcluster-phbngt/hello-template available condition is not true, [{Progressing True 0 2024-07-05 04:47:53 +0000 UTC Progressing progressing... work is not ready} {RegistrationApplied True 0 2024-07-05 04:47:53 +0000 UTC SetPermissionApplied Registration of the addon agent is configured} {ClusterCertificateRotated False 0 2024-07-05 04:47:53 +0000 UTC ClientCertificateUpdateFailed Failed to rotated client certificate namespaces \"open-cluster-management-agent-addon\" not found} {ManifestApplied False 0 2024-07-05 04:47:53 +0000 UTC AddonManifestAppliedFailed failed to apply the manifests of addon} {Available False 0 2024-07-05 04:47:53 +0000 UTC WorkNotApplied 3 of 4 resources are not available}]",
      }

From the log, you can see the root cause is because:

ClusterCertificateRotated False 0 2024-07-05 04:47:53 +0000 UTC ClientCertificateUpdateFailed Failed to rotated client certificate namespaces \"open-cluster-management-agent-addon\" not found

This is because currently, the namespace for addons are fixed to be: open-cluster-management-agent-addon. Currently we have 5 places to cleanKlusterletResources:

There are chances that open-cluster-management-agent is cleaned up, and then addon-manager start to test its case.

BUT, addon-manager is using the universal klusterlet create at the init of the e2e, that klusterlet is not changed, so the controller won't be reconcile to create open-cluster-management-agent-addon again.

That's the reason why we have the namespaces \"open-cluster-management-agent-addon\" not found error.

---

A simple way to fix it is using another ns in addon-manager cases.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.41%. Comparing base (b3f15c1) to head (164c90a).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   62.41%   62.41%           
=======================================
  Files         177      177           
  Lines       13857    13857           
=======================================
  Hits         8649     8649           
  Misses       4339     4339           
  Partials      869      869           

Flag	Coverage Δ
unit	62.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xuezhaojun]

/assign @zhujian7
please take a review, thanks!

/assign @qiujian16
please approve, thanks!

[zhujian7]

/lgtm

[qiujian16]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [qiujian16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment