Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Set default user-agent for work to work-agent #588

Conversation

qiujian16
Copy link
Member

@qiujian16 qiujian16 commented Aug 6, 2024

Summary

Related issue(s)

Fixes #586

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.57%. Comparing base (33e900b) to head (e36e029).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   62.60%   63.57%   +0.97%     
==========================================
  Files         181      181              
  Lines       13964    13967       +3     
==========================================
+ Hits         8742     8880     +138     
+ Misses       4338     4192     -146     
- Partials      884      895      +11     
Flag Coverage Δ
unit 63.57% <100.00%> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16 qiujian16 force-pushed the default-user-agent branch from 811de09 to 3466e5d Compare August 6, 2024 04:47
Signed-off-by: Jian Qiu <jqiu@redhat.com>
@qiujian16 qiujian16 force-pushed the default-user-agent branch from 3466e5d to e36e029 Compare August 6, 2024 05:40
Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skeeey
Copy link
Member

skeeey commented Aug 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c9161ce into open-cluster-management-io:main Aug 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ManifestWork set fileManager to "work" instead of "work-agent" when use "Update" type of updateStrategy
2 participants