-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 return raw data of chart render results #593
🌱 return raw data of chart render results #593
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
- Coverage 63.74% 63.71% -0.03%
==========================================
Files 181 181
Lines 14039 14021 -18
==========================================
- Hits 8949 8934 -15
+ Misses 4195 4193 -2
+ Partials 895 894 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
be0dac2
to
d25c9ba
Compare
Can we add the motivation of this PR? Like improve performance? |
/assign @qiujian16 |
@xuezhaojun to return raw data will be easy for other components to consume, like clusteradm . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e137912
into
open-cluster-management-io:main
Summary
update operator charts render function to return raw data of the results.
Related issue(s)
Fixes #