Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 return raw data of chart render results #593

Conversation

zhiweiyin318
Copy link
Member

Summary

update operator charts render function to return raw data of the results.

Related issue(s)

Fixes #

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.71%. Comparing base (dfa835d) to head (d25c9ba).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/operator/helpers/chart/render.go 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
- Coverage   63.74%   63.71%   -0.03%     
==========================================
  Files         181      181              
  Lines       14039    14021      -18     
==========================================
- Hits         8949     8934      -15     
+ Misses       4195     4193       -2     
+ Partials      895      894       -1     
Flag Coverage Δ
unit 63.71% <81.25%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
@xuezhaojun
Copy link
Member

Can we add the motivation of this PR? Like improve performance?

@zhiweiyin318
Copy link
Member Author

/assign @qiujian16

@zhiweiyin318
Copy link
Member Author

Can we add the motivation of this PR? Like improve performance?

@xuezhaojun to return raw data will be easy for other components to consume, like clusteradm .

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 15, 2024
Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e137912 into open-cluster-management-io:main Aug 15, 2024
15 checks passed
@zhiweiyin318 zhiweiyin318 deleted the update-chart-render branch August 15, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants