Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix token-secret format #606

Conversation

zhiweiyin318
Copy link
Member

Summary

Related issue(s)

Fixes #

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
@zhiweiyin318
Copy link
Member Author

/assign @qiujian16

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.86%. Comparing base (7946f87) to head (16f0676).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   63.87%   63.86%   -0.01%     
==========================================
  Files         180      180              
  Lines       14100    14100              
==========================================
- Hits         9006     9005       -1     
  Misses       4193     4193              
- Partials      901      902       +1     
Flag Coverage Δ
unit 63.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 30, 2024
Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 41c9196 into open-cluster-management-io:main Aug 30, 2024
15 checks passed
@zhiweiyin318 zhiweiyin318 deleted the fix-token-secret branch August 30, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants