Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 revert golang version to 1.22.5 #610

Merged

Conversation

haoqing0110
Copy link
Member

@haoqing0110 haoqing0110 commented Sep 4, 2024

Summary

Revert golang version to 1.22.5 since Cachito doesn't support 1.22.6 yet.

Related issue(s)

Fixes #

Signed-off-by: haoqing0110 <qhao@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and jnpacker September 4, 2024 01:58
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.86%. Comparing base (1fc820a) to head (71aab47).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #610   +/-   ##
=======================================
  Coverage   63.86%   63.86%           
=======================================
  Files         180      180           
  Lines       14100    14100           
=======================================
  Hits         9005     9005           
  Misses       4193     4193           
  Partials      902      902           
Flag Coverage Δ
unit 63.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoqing0110 haoqing0110 closed this Sep 4, 2024
@haoqing0110 haoqing0110 reopened this Sep 5, 2024
@haoqing0110
Copy link
Member Author

/assign @qiujian16

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 5, 2024
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a25a4e0 into open-cluster-management-io:main Sep 5, 2024
27 checks passed
@haoqing0110 haoqing0110 deleted the br_revert branch September 5, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants