🐛 only read the first item when RawFeedbackJsonString is disabled #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to ensure the backward compatible when the feature gate is disabled Signed-off-by: Jian Qiu <jqiu@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold for test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 63.86% 63.92% +0.05%
==========================================
Files 180 180
Lines 14100 14116 +16
==========================================
+ Hits 9005 9023 +18
+ Misses 4193 4191 -2
Partials 902 902
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/lgtm |
Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
fix-json-raw
branch
from
164c47b to
0981ffa
Compare
|
/lgtm |
|
/unhold |
openshift-merge-bot
bot
merged commit 8678ede
into
open-cluster-management-io:main
15 checks passed
haoqing0110
pushed a commit
to haoqing0110/OCM
that referenced
this pull request
Sep 9, 2024
…en-cluster-management-io#613) * only read the first item when RawFeedbackJsonString is disabled This is to ensure the backward compatible when the feature gate is disabled Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add a test for backward compatible Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>
zhujian7
pushed a commit
to zhujian7/ocm
that referenced
this pull request
Sep 9, 2024
…en-cluster-management-io#613) * only read the first item when RawFeedbackJsonString is disabled This is to ensure the backward compatible when the feature gate is disabled Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add a test for backward compatible Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>
openshift-merge-bot bot
pushed a commit
to stolostron/ocm
that referenced
this pull request
Sep 10, 2024
…en-cluster-management-io#613) (#121) * only read the first item when RawFeedbackJsonString is disabled This is to ensure the backward compatible when the feature gate is disabled * Add a test for backward compatible --------- Signed-off-by: Jian Qiu <jqiu@redhat.com> Co-authored-by: Jian Qiu <jqiu@redhat.com>
openshift-merge-bot bot
pushed a commit
to stolostron/ocm
that referenced
this pull request
Sep 10, 2024
…en-cluster-management-io#613) (#122) * only read the first item when RawFeedbackJsonString is disabled This is to ensure the backward compatible when the feature gate is disabled * Add a test for backward compatible --------- Signed-off-by: Jian Qiu <jqiu@redhat.com> Co-authored-by: Jian Qiu <jqiu@redhat.com>
haoqing0110
pushed a commit
to haoqing0110/OCM
that referenced
this pull request
Sep 11, 2024
…en-cluster-management-io#613) * only read the first item when RawFeedbackJsonString is disabled This is to ensure the backward compatible when the feature gate is disabled Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add a test for backward compatible Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>
This was referenced Sep 11, 2024
openshift-merge-bot bot
pushed a commit
to stolostron/ocm
that referenced
this pull request
Sep 11, 2024
…en-cluster-management-io#613) (#124) * only read the first item when RawFeedbackJsonString is disabled This is to ensure the backward compatible when the feature gate is disabled * Add a test for backward compatible --------- Signed-off-by: Jian Qiu <jqiu@redhat.com> Co-authored-by: Jian Qiu <jqiu@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure the backward compatible when the feature gate is disabled
Summary
Related issue(s)
Fixes #