Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fix error message #628

Merged

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Sep 23, 2024

Summary

Fix error message in PR open-cluster-management-io/registration-operator#363

Related issue(s)

Fixes #

Signed-off-by: zhujian <jiazhu@redhat.com>
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.91%. Comparing base (7772622) to head (db67e2d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/operator/operators/crdmanager/manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
- Coverage   63.92%   63.91%   -0.01%     
==========================================
  Files         180      180              
  Lines       14116    14116              
==========================================
- Hits         9023     9022       -1     
- Misses       4191     4192       +1     
  Partials      902      902              
Flag Coverage Δ
unit 63.91% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jnpacker
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit abec12a into open-cluster-management-io:main Sep 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants