Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 handle the unknown status of the previously accepted cluster #656

Conversation

elgnay
Copy link
Contributor

@elgnay elgnay commented Oct 18, 2024

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from ldpliu and skeeey October 18, 2024 04:11
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.05%. Comparing base (9181dbb) to head (18324f5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
+ Coverage   63.00%   63.05%   +0.04%     
==========================================
  Files         182      182              
  Lines       17604    17605       +1     
==========================================
+ Hits        11091    11100       +9     
+ Misses       5601     5593       -8     
  Partials      912      912              
Flag Coverage Δ
unit 63.05% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elgnay elgnay force-pushed the previously_accepted_cluster_unknown branch from 68950d8 to e516eff Compare October 18, 2024 06:50
Signed-off-by: Yang Le <yangle@redhat.com>
@elgnay elgnay force-pushed the previously_accepted_cluster_unknown branch from e516eff to 18324f5 Compare October 18, 2024 07:36
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9a47edc into open-cluster-management-io:main Oct 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants