Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links point to the repo ocm. #361

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Jun 5, 2023

The related issue: open-cluster-management-io/ocm#128

The fmt tool automatically delete some spaces in markdown files, but I also explicitly point out the changes using commits.

Signed-off-by: xuezhaojun <zxue@redhat.com>
building blocks, except for the mandatory core module named [registration](https://github.com/open-cluster-management-io/registration)
which is responsible for controlling the lifecycle of a managed controller
be freely-pluggable by modularizing the atomic capability into separated
building blocks, except for the mandatory core module named [registration](https://github.com/open-cluster-management-io/ocm/tree/main/cmd/registration)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to pointing to ocm repo the /cmd/registration

@@ -88,7 +88,7 @@ gracefully with permission and validity under control.


Note that the functionality mentioned above are all managed by OCM's
[registration](https://github.com/open-cluster-management-io/registration)
[registration](https://github.com/open-cluster-management-io/ocm/tree/main/cmd/registration)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the changes.

The user can move the cluster from the default clusterset to another clusterset using the command:
```
clusteradm clusterset set target-clusterset --clusters cluster-name
```

`default` clusterset is an alpha feature that can be disabled by disabling the feature gate in registration controller as:
[`- "--feature-gates=DefaultClusterSet=false"`](https://github.com/open-cluster-management-io/registration-operator/commit/55bc274d795ad0befc71f05aecd08810a4abfba1#diff-1026afceb1a224783dbf517bc281e71c1640636f5f001338f8185a0b4398b3d9R51)
[`- "--feature-gates=DefaultClusterSet=false"`](https://github.com/open-cluster-management-io/ocm/commit/55bc274d795ad0befc71f05aecd08810a4abfba1#diff-1026afceb1a224783dbf517bc281e71c1640636f5f001338f8185a0b4398b3d9R51)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the changes.

@@ -11,7 +11,7 @@ weight: 2

## What is `ManifestWork`

`ManifestWork` is used to define a group of Kubernetes resources on the hub to be applied to the managed cluster. In the open-cluster-management project, a `ManifestWork` resource must be created in the cluster namespace. A work agent implemented in [work](https://github.com/open-cluster-management-io/work) project is run on the managed cluster and monitors the `ManifestWork` resource in the cluster namespace on the hub cluster.
`ManifestWork` is used to define a group of Kubernetes resources on the hub to be applied to the managed cluster. In the open-cluster-management project, a `ManifestWork` resource must be created in the cluster namespace. A work agent implemented in [work](https://github.com/open-cluster-management-io/ocm/tree/main/cmd/work) project is run on the managed cluster and monitors the `ManifestWork` resource in the cluster namespace on the hub cluster.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the changes.

@@ -13,7 +13,7 @@ All contributions are welcome! Open Cluster Management uses the [Apache 2 licens

- Join the [Mailing group](https://groups.google.com/g/open-cluster-management)
- Attend an upcoming [Community meetings](https://github.com/open-cluster-management-io/community/projects/1)
- Fork the [repository](https://github.com/open-cluster-management-io) you wish to work on. For example, [API](https://github.com/open-cluster-management-io/api),[Registration](https://github.com/open-cluster-management-io/registration), etc.
- Fork the [repository](https://github.com/open-cluster-management-io) you wish to work on. For example, [API](https://github.com/open-cluster-management-io/api),[ocm](https://github.com/open-cluster-management-io/ocm), etc.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the changes.

@@ -56,7 +56,7 @@ Call `clusteradm init`:
```

The `clusteradm init` command installs the
[registration-operator](https://github.com/open-cluster-management-io/registration-operator)
[registration-operator](https://github.com/open-cluster-management-io/ocm/tree/main/cmd/registration-operator)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the changes.

@@ -69,7 +69,7 @@ rules:

## 实现细节

所有认证授权和秘钥管理的代码实现都在[registration](https://github.com/open-cluster-management-io/registration)组件中。大概的流程
所有认证授权和秘钥管理的代码实现都在[registration](https://github.com/open-cluster-management-io/ocm/tree/main/cmd/registration)组件中。大概的流程
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the changes.

@@ -47,7 +47,7 @@ hub cluster的负担将会大大减轻,因为hub cluster既不需要处理来
### 模块化和可扩展性

OCM不仅会给您带来流畅的用户体验,让您轻松管理多个集群,而且对进一步定制或二次开发同样友好。
OCM中每一个功能,都可以通过将原子能力模块化到单独的构建块中,来实现自由拔插,除了了一个名为[registration](https://github.com/open-cluster-management-io/registration)的强制性核心模块,此模块负责控制managed控制器的生命周期,并导出基本的`ManagedCluster`模型。
OCM中每一个功能,都可以通过将原子能力模块化到单独的构建块中,来实现自由拔插,除了了一个名为[registration](https://github.com/open-cluster-management-io/ocm/tree/main/cmd/registration)的强制性核心模块,此模块负责控制managed控制器的生命周期,并导出基本的`ManagedCluster`模型。
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the changes.

@@ -88,7 +88,7 @@ gracefully with permission and validity under control.


Note that the functionality mentioned above are all managed by OCM's
[registration](https://github.com/open-cluster-management-io/registration)
[registration](https://github.com/open-cluster-management-io/ocm/tree/main/cmd/registration)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the changes.

The user can move the cluster from the default clusterset to another clusterset using the command:
```
clusteradm clusterset set target-clusterset --clusters cluster-name
```

`default` clusterset is an alpha feature that can be disabled by disabling the feature gate in registration controller as:
[`- "--feature-gates=DefaultClusterSet=false"`](https://github.com/open-cluster-management-io/registration-operator/commit/55bc274d795ad0befc71f05aecd08810a4abfba1#diff-1026afceb1a224783dbf517bc281e71c1640636f5f001338f8185a0b4398b3d9R51)
[`- "--feature-gates=DefaultClusterSet=false"`](https://github.com/open-cluster-management-io/ocm/commit/55bc274d795ad0befc71f05aecd08810a4abfba1#diff-1026afceb1a224783dbf517bc281e71c1640636f5f001338f8185a0b4398b3d9R51)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the changes.

@@ -11,7 +11,7 @@ weight: 2

## What is `ManifestWork`

`ManifestWork` is used to define a group of Kubernetes resources on the hub to be applied to the managed cluster. In the open-cluster-management project, a `ManifestWork` resource must be created in the cluster namespace. A work agent implemented in [work](https://github.com/open-cluster-management-io/work) project is run on the managed cluster and monitors the `ManifestWork` resource in the cluster namespace on the hub cluster.
`ManifestWork` is used to define a group of Kubernetes resources on the hub to be applied to the managed cluster. In the open-cluster-management project, a `ManifestWork` resource must be created in the cluster namespace. A work agent implemented in [work](https://github.com/open-cluster-management-io/ocm/tree/main/cmd/work) project is run on the managed cluster and monitors the `ManifestWork` resource in the cluster namespace on the hub cluster.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the changes.

@@ -13,7 +13,7 @@ All contributions are welcome! Open Cluster Management uses the [Apache 2 licens

- Join the [Mailing group](https://groups.google.com/g/open-cluster-management)
- Attend an upcoming [Community meetings](https://github.com/open-cluster-management-io/community/projects/1)
- Fork the [repository](https://github.com/open-cluster-management-io) you wish to work on. For example, [API](https://github.com/open-cluster-management-io/api),[Registration](https://github.com/open-cluster-management-io/registration), etc.
- Fork the [repository](https://github.com/open-cluster-management-io) you wish to work on. For example, [API](https://github.com/open-cluster-management-io/api),[ocm](https://github.com/open-cluster-management-io/ocm), etc.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the changes.

@xuezhaojun
Copy link
Member Author

/assign @qiujian16

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit a0ce111 into open-cluster-management-io:main Jun 5, 2023
@xuezhaojun xuezhaojun deleted the update-repo-links branch June 5, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants