update addon develop guide #410
Conversation
|
/hold |
Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_addon-dev
branch
from
9760ff2 to
c97b679
Compare
|
/unhold |
|
/assign @qiujian16 @zhiweiyin318 |
|
/lgtm |
content/en/developer-guides/addon.md
Outdated
| @@ -11,6 +11,12 @@ This page is a developer guide about how to build an OCM add-on using addon-fram | |||
|
|
|||
| <!-- spellchecker-enable --> | |||
|
|
|||
| ## Supported version | |||
|
|
|||
| The OCM v0.14.0 requires addon-framework v0.8.1 and above versions. | |||
There was a problem hiding this comment.
we have not released yet. This annoucement should be noted only we are about to release
There was a problem hiding this comment.
modified the doc to only focus on the released version. will create and hold another PR for v0.14.0.
content/en/developer-guides/addon.md
Outdated
| @@ -394,6 +404,34 @@ agentAddon, err := addonfactory.NewAgentAddonFactory(addonName, FS, "manifests") | |||
| BuildTemplateAgentAddon() | |||
| ``` | |||
|
|
|||
| Addtionally, need to grant a `patch` permission on `ClusterManagementAddon` to your addon manager. | |||
There was a problem hiding this comment.
This is the requirement for 0.8.1, right?
There was a problem hiding this comment.
Yes, and 0.9.0 as well. Have updated the content.
Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_addon-dev
branch
from
9caeb0e to
580b422
Compare
Co-authored-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_addon-dev
branch
from
4e57b8d to
eab12d7
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 16e9339
into
open-cluster-management-io:main
Ref: open-cluster-management-io/ocm#355