Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links #425

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Fix broken links #425

merged 1 commit into from
Jul 5, 2024

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Jul 5, 2024

@zhujian7
Fix broken links
8e67374 
Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7 zhujian7 marked this pull request as ready for review July 5, 2024 07:36
@openshift-ci openshift-ci bot requested review from dhaiducek and mprahl July 5, 2024 07:36
@zhujian7 zhujian7 mentioned this pull request Jul 5, 2024
Merged
@zhujian7
Copy link
Member Author

zhujian7 commented Jul 5, 2024

/cc @z1ens

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

@zhujian7: GitHub didn't allow me to request PR reviews from the following users: z1ens.

Note that only open-cluster-management-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @z1ens

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mikeshng
mikeshng approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 46175ce into open-cluster-management-io:main Jul 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeshng mikeshng mikeshng approved these changes

@dhaiducek dhaiducek Awaiting requested review from dhaiducek

@mprahl mprahl Awaiting requested review from mprahl

Assignees

@mikeshng mikeshng

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhujian7 @mikeshng