Using requeue cluster instead of resync lease controller #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
refer to open-cluster-management-io/ocm#117 |
qiujian16
reviewed
Dec 6, 2022
| @@ -26,6 +26,7 @@ import ( | |||
|
|
|||
| const leaseDurationTimes = 5 | |||
| const leaseName = "managed-cluster-lease" | |||
| const clusterNameLabel = "open-cluster-management.io/cluster-name" | |||
There was a problem hiding this comment.
we should put all common lables/annotations in the api repo with good documents. Please create an issue in api repo.
There was a problem hiding this comment.
created an issue for this open-cluster-management-io/api#194
skeeey
changed the title
qiujian16
reviewed
Dec 7, 2022
| @@ -169,3 +195,15 @@ func assertAvailableCondition(managedClusterName string, status metav1.Condition | |||
| return nil | |||
| }, eventuallyTimeout, eventuallyInterval).ShouldNot(gomega.HaveOccurred()) | |||
| } | |||
|
|
|||
| func updateManagedCluster(clusterName string, leaseDuration int32) error { | |||
There was a problem hiding this comment.
nit: updateManagedClusterLeaseDuration
Signed-off-by: Wei Liu <liuweixa@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, skeeey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wei Liu liuweixa@redhat.com