Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix annotation and label removal issues in work #29

Conversation

haoqing0110
Copy link
Member

Summary

Related issue(s)

Fix the issue to remove annotations from work when it's nil in WorkApplier.Apply().

Fixes #

Signed-off-by: haoqing0110 <qhao@redhat.com>
@haoqing0110
Copy link
Member Author

/assign @qiujian16 @zhiweiyin318

@qiujian16
Copy link
Member

/approve

Copy link

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhiweiyin318
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit aa744f4 into open-cluster-management-io:main Apr 16, 2024
10 checks passed
@haoqing0110 haoqing0110 deleted the br_fix-annotations branch April 16, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants