-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizing secret event sources #88
Conversation
/assign @qiujian16 |
/assign @zhiweiyin318 |
/assign @zhujian7 |
Namespace: managedClusterName, | ||
Name: constants.AutoImportSecretName, | ||
}, autoImportSecret) | ||
autoImportSecret, err := r.kubeClient.CoreV1().Secrets(managedClusterName).Get(ctx, constants.AutoImportSecretName, metav1.GetOptions{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we use lister here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, we should consider it, I will add a TODO firstly
} | ||
|
||
// NewAutoImportSecretSource return a SecretSource only for auto import secrets | ||
func NewAutoImportSecretSource(secretInformer cache.SharedIndexInformer) *SecretSource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems duplicate with NewImportSecretSource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use different name to distinguish different informer
Can we hold this PR temporarily? |
Signed-off-by: liuwei <liuweixa@redhat.com>
Kudos, SonarCloud Quality Gate passed! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: skeeey, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yesterday I found the
But we need the It is close to
OR
/hold cancel |
Signed-off-by: liuwei liuweixa@redhat.com