Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(condo): DOMA-8487 create pushes for decline incoming voip call #4421

Conversation

VKislov
Copy link
Contributor

@VKislov VKislov commented Feb 24, 2024

Partners must call a custom mutation sendB2CAppPushMessage with certain parameters and, using these parameters, send a push (regular, not voip) to all devices of a particular resident. When using types, the call is accepted by one of the resident devices and canceled by the caller. At the moment DECLINED_BY_CALLER and RECEIVED_ON_DEVICE are all types, later the list may expand.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe write documentation for this mutation? Looks like it's getting more and more complicated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about tests for new errors? :)

@VKislov VKislov force-pushed the feat/condo/DOMA-8487/pushes-for-decline-incomming-voip-message branch from 4ef50cd to b87fd15 Compare March 4, 2024 07:00
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@SavelevMatthew SavelevMatthew added the ☠ Dead / 🐞 Debug Needs to be closed. You don't need to look at this PR label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☠ Dead / 🐞 Debug Needs to be closed. You don't need to look at this PR
Development

Successfully merging this pull request may close these issues.

4 participants