New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(condo): INFRA-202 multiple database sources #4618

Open

sitozzz wants to merge 37 commits into master from feat/condo/INFRA-202/multiple-database-sources

Member

sitozzz commented Apr 15, 2024 •

edited

Loading

Need to deal with adapter cache!!!
Stand tests
Load tests

sitozzz force-pushed the feat/condo/INFRA-202/multiple-database-sources branch 5 times, most recently from 6a93b34 to db441c8 Compare

April 29, 2024 13:22

sitozzz force-pushed the feat/condo/INFRA-202/multiple-database-sources branch 3 times, most recently from 1f957e4 to 046aaa6 Compare

May 6, 2024 06:48

sitozzz marked this pull request as ready for review

May 6, 2024 10:48

sitozzz added 👶 small ✋🙂 Review please labels

pahaz reviewed

View reviewed changes

.github/workflows/_nodejs.condo.core.tests.yml Outdated Show resolved Hide resolved

sitozzz force-pushed the feat/condo/INFRA-202/multiple-database-sources branch 4 times, most recently from db580d7 to 04db392 Compare

May 24, 2024 10:39

sitozzz force-pushed the feat/condo/INFRA-202/multiple-database-sources branch from 04db392 to 87a36fd Compare

June 1, 2024 05:08

sitozzz force-pushed the feat/condo/INFRA-202/multiple-database-sources branch 2 times, most recently from 08e8972 to 3c91f98 Compare

June 13, 2024 05:52

SavelevMatthew reviewed

View reviewed changes

packages/keystone/databaseAdapters/ReplicaKnexAdapter.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

packages/keystone/databaseAdapters/ReplicaKnexAdapter.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

packages/keystone/databaseAdapters/ReplicaKnexAdapter.js Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

packages/keystone/databaseAdapters/ReplicaKnexAdapter.js Outdated Show resolved Hide resolved

SavelevMatthew reviewed

View reviewed changes

packages/keystone/databaseAdapters/utils.js Show resolved Hide resolved

sitozzz force-pushed the feat/condo/INFRA-202/multiple-database-sources branch from 3c91f98 to 5e1cab2 Compare

June 24, 2024 07:42

sitozzz mentioned this pull request

feat/condo/infra-200/postgres-ha #4824

Closed

sitozzz requested review from SavelevMatthew and pahaz

June 26, 2024 08:07

SavelevMatthew reviewed

View reviewed changes

packages/keystone/databaseAdapters/ReplicaKnexAdapter.js Outdated Show resolved Hide resolved

sitozzz force-pushed the feat/condo/INFRA-202/multiple-database-sources branch from 93c44da to d51271a Compare

June 27, 2024 12:12

sitozzz added 6 commits

July 8, 2024 08:29


          refactor(keystone): INFRA-202 rename connections & provide more speci…

3750ad4

…fic operation list


          fix(keystone): INFRA-202 extend mutable operations config at ReplicaK…

b753bb8

…nexAdapter


          fix(keystone): INFRA-202 add del alias & provide debug logging for mi…

2f6bd36

…grations problem investigation


          fix(global): INFRA-200 rid off ini file configuration & remove debug …

4ab920e

…logs


          fix(global): INFRA-202 rebase with origin

e747db3


          chore(global): INFRA-200 point to infra changes after rebase

5f5c414

sitozzz requested a review from SavelevMatthew

July 8, 2024 04:10


          fix(condo): INFRA-202 try to enable custom db adapter for test runs

4466c7f

sitozzz force-pushed the feat/condo/INFRA-202/multiple-database-sources branch from 22f3eb5 to 4466c7f Compare

July 8, 2024 04:19

sitozzz had a problem deploying to internal

July 8, 2024 04:19

— with

GitHub Actions Error

sitozzz temporarily deployed to internal

July 8, 2024 04:19

— with

GitHub Actions Inactive


          fix(condo): INFRA-202 try to enable custom db adapter for test runs

b28a569

sitozzz temporarily deployed to internal

July 8, 2024 04:22

— with

GitHub Actions Inactive


          fix(condo): INFRA-202 try to enable custom db adapter for test runs

b8c078d

sitozzz temporarily deployed to internal

July 8, 2024 07:15

— with

GitHub Actions Inactive

github-advanced-security bot found potential problems

View reviewed changes

bin/prepare.js Dismissed Show dismissed Hide dismissed

bin/prepare.js Dismissed Show dismissed Hide dismissed

sitozzz temporarily deployed to internal

July 8, 2024 07:58

— with

GitHub Actions Inactive


          fix(condo): INFRA-202 try to enable custom db adapter for test runs

6423e2f

sitozzz had a problem deploying to internal

July 8, 2024 08:19

— with

GitHub Actions Error

sitozzz temporarily deployed to internal

July 8, 2024 08:19

— with

GitHub Actions Inactive


          fix(condo): INFRA-202 try to enable custom db adapter for test runs

c8698d5

sitozzz had a problem deploying to internal

July 8, 2024 09:39

— with

GitHub Actions Error

sitozzz temporarily deployed to internal

July 8, 2024 09:39

— with

GitHub Actions Inactive

SavelevMatthew reviewed

View reviewed changes

.github/workflows/nodejs.condo.ci.yml

@@ @@ -4,7 +4,7 @@ on: @@
                 push:
                   branches:
                     - master
-                pull_request_target:
+                pull_request:

Member

SavelevMatthew Jul 9, 2024

Don't forget to switch triggers back

Member Author

sitozzz Jul 9, 2024

thank you I won't forget

SavelevMatthew reviewed

View reviewed changes

apps/condo/package.json Outdated

@@ @@ -212,5 +212,6 @@ @@
                 },
                 "resolutions": {
                   "@types/react": "16.9.17"
-                }
+                },
+                "dbAdapters": ["ReplicaKnexAdapter"]

Member

SavelevMatthew Jul 9, 2024

what's this?

Member

SavelevMatthew Jul 9, 2024

I guess CLI arg will be preferable in prepare

SavelevMatthew reviewed

View reviewed changes

packages/keystone/databaseAdapters/ReplicaKnexAdapter.js Outdated


		const logger = getLogger('replicaKnexAdapter')

		const MUTABLE_OPERATIONS = ['create', 'update', 'insert', 'delete', 'alter', 'drop', 'truncate', 'rollback', 'del']

Member

SavelevMatthew Jul 9, 2024

IMHO reverted ops are better (explicitly specify, what to take from replica). And if not sure - go to main db

SavelevMatthew approved these changes

View reviewed changes


          refactor(global): INFRA-202 move replication env setting to program a…

bbc5e5e

…rgs & invert replica selection filtering query

sitozzz temporarily deployed to internal

July 9, 2024 09:49

— with

GitHub Actions Inactive

sonarcloud bot commented Jul 9, 2024

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment