feat(condo): DOMA-8896 add ticket submitting disabling for organization with service_provider type #4801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on with service_provider type
VKislov
force-pushed
the
feat/condo/DOMA-8896/add-disabling-tickets-for-rso
branch
from
439d801
to
1ef2f96
Compare
pahaz
reviewed
Jun 6, 2024
| @@ -32,13 +33,15 @@ const INPUT_LAYOUT_PROPS = { | |||
| const BIG_ROW_GUTTERS: [Gutter, Gutter] = [0, 60] | |||
| const MIDDLE_ROW_GUTTERS: [Gutter, Gutter] = [0, 40] | |||
| const SMALL_ROW_GUTTERS: [Gutter, Gutter] = [0, 20] | |||
| const redirectUrl = '/settings?tab=mobileFeatureConfig' | |||
pahaz
reviewed
Jun 6, 2024
|
|
||
| await expectToThrowGQLError( | ||
| async () => await createTestMobileFeatureConfig(admin, organization, { | ||
| ticketSubmittingWithoutPhoneIsDisabled: true, |
There was a problem hiding this comment.
During the design process the field name changed, it should be ticketSubmittingForServiceProviderOrgIsDisabled.
There is a commonPhone field. When disabling tickets from a mobile phone in a managing company, filling out commonPhone is required. If tickets are disabled by the service provider then the phone must be optional
pahaz
requested changes
Jun 6, 2024
| -- | ||
| ALTER TABLE "MobileFeatureConfig" ADD COLUMN "ticketSubmittingForServiceProviderOrgIsDisabled" boolean NULL; | ||
| -- | ||
| -- Add field ticketSubmittingForServiceProviderOrgIsDisabled to mobilefeatureconfighistoryrecord |
…roviderOrgIsDisabled field
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.