fix(condo): remove Yandex Metrica if there is no runtime configuration #4867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nc-open-condo/remove-yandex-metrica-from-runtime # Conflicts: # apps/condo/pages/_app.tsx
toplenboren
approved these changes
Jun 26, 2024
pahaz
approved these changes
Jun 28, 2024
|
I'm happy to announce that we now know how to handle PRs and CI/CDs from forks 🥳 Please rebase your branch on the current master, after that the new CI will work and we will be able to accept your PRs ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it is possible to omit adding a metric component if the corresponding variables, such as yandexMetricaID, are not provided