fix(condo): DOMA-10006 add throttling #5126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pahaz
approved these changes
Aug 20, 2024
| @@ -237,11 +238,13 @@ export const RecipientCounter: React.FC<RecipientCounterProps> = ({ newsItemScop | |||
| }, | |||
| ) | |||
|
|
|||
| const throttledGetCounters = useCallback(throttle(getCounters, 1500), [throttle]) | |||
There was a problem hiding this comment.
Why getCounters not in deps array? To avoid callback rerender?
There was a problem hiding this comment.
btw, throttle is imported function, its not necessary to put it in deps
There was a problem hiding this comment.
And why 1500? I'm almost sure we can reproduce error consistently with this value
| @@ -266,6 +269,9 @@ export const RecipientCounter: React.FC<RecipientCounterProps> = ({ newsItemScop | |||
|
|
|||
| const isLoadingCounters = isCountersLoading || !counters | |||
|
|
|||
| console.log('Recipient counter', { isLoadingCounters, isCountersLoading, counters }) | |||
ekabardinsky
pushed a commit
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.