Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(condo): DOMA-10055 added timeouts to batch functions #5145

Merged

Conversation

nomerdvadcatpyat
Copy link
Member

No description provided.

@nomerdvadcatpyat nomerdvadcatpyat added 👶 small Easy to review changes up to 50 lines of code ✋🙂 Review please Comments are resolved, take a look, please labels Aug 27, 2024
Copy link
Member

@sitozzz sitozzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ok

apps/condo/domains/common/utils/serverSchema/index.js Outdated Show resolved Hide resolved
apps/condo/domains/common/utils/serverSchema/index.js Outdated Show resolved Hide resolved
apps/condo/domains/common/utils/serverSchema/index.js Outdated Show resolved Hide resolved
@nomerdvadcatpyat nomerdvadcatpyat force-pushed the feat/condo/DOMA-10055/added-timeouts-to-batch-functions branch from 225b7ba to 0aaf876 Compare August 27, 2024 15:38
Copy link
Member

@sitozzz sitozzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks really good to me

@nomerdvadcatpyat nomerdvadcatpyat force-pushed the feat/condo/DOMA-10055/added-timeouts-to-batch-functions branch from 21fac68 to 148eeff Compare August 27, 2024 15:59
@nomerdvadcatpyat nomerdvadcatpyat force-pushed the feat/condo/DOMA-10055/added-timeouts-to-batch-functions branch from 148eeff to 9047ec0 Compare August 27, 2024 16:04
@nomerdvadcatpyat nomerdvadcatpyat force-pushed the feat/condo/DOMA-10055/added-timeouts-to-batch-functions branch from 9047ec0 to d02a1d7 Compare August 27, 2024 16:04
@nomerdvadcatpyat nomerdvadcatpyat force-pushed the feat/condo/DOMA-10055/added-timeouts-to-batch-functions branch from d02a1d7 to 2bd3b24 Compare August 27, 2024 16:20
@nomerdvadcatpyat nomerdvadcatpyat merged commit b501a70 into main Aug 27, 2024
6 of 7 checks passed
@nomerdvadcatpyat nomerdvadcatpyat deleted the feat/condo/DOMA-10055/added-timeouts-to-batch-functions branch August 27, 2024 16:49
Copy link

sonarcloud bot commented Aug 27, 2024

Alllex202 pushed a commit that referenced this pull request Aug 27, 2024
* feat(condo): DOMA-10055 added timeout to chunk functions

* feat(condo): DOMA-10055 added logs

* feat(condo): DOMA-10055 update schemaName log and env check

(cherry picked from commit b501a70)
Alllex202 pushed a commit that referenced this pull request Aug 27, 2024
* feat(condo): DOMA-10055 added timeout to chunk functions

* feat(condo): DOMA-10055 added logs

* feat(condo): DOMA-10055 update schemaName log and env check

(cherry picked from commit b501a70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✋🙂 Review please Comments are resolved, take a look, please 👶 small Easy to review changes up to 50 lines of code
Development

Successfully merging this pull request may close these issues.

5 participants