Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch grading data format in CourseEnrollmentSerializer #298

Merged

Conversation

kaizoku
Copy link

@kaizoku kaizoku commented Dec 15, 2020

This updates the format of the grading key from the CourseEnrollmentSerializer to remove the unnecessary wrapping in a list since it will always be a single item.

JIRA tickets: BB-3440

Merge deadline: Promptly

Testing instructions:
Check the format of the grading key under the course enrollments API and ensure it's not a list: http://localhost:18000/api/enrollment/v1/enrollment?user=honor

Author notes and concerns:

  1. The final format of upstream changes this endpoint is still under discussion on https://github.com/edx/edx-platform/pull/20948/files

Reviewers

  • 0x29a

Copy link
Member

@0x29a 0x29a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I didn't manage to test this because I have no ironwood devstack and setting up working fork locally will take too much time for such trivial change.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@kaizoku kaizoku changed the base branch from opencraft-release/ironwood.2-asu-ytp to opencraft-release/ironwood.2 December 15, 2020 15:10
@kaizoku kaizoku force-pushed the BB-3440-enrollment-grading-data-format branch from 233a441 to def1cd2 Compare December 15, 2020 15:15
@kaizoku
Copy link
Author

kaizoku commented Dec 15, 2020

Thanks @0x29a. I switched this to our common Ironwood branch since I found this customization is also a part of it.

@kaizoku kaizoku merged commit b559589 into opencraft-release/ironwood.2 Dec 18, 2020
@bradenmacdonald bradenmacdonald deleted the BB-3440-enrollment-grading-data-format branch January 12, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants