Prevent Duplicate Keys Across Table Definitions #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent duplicate dataset types. - Prevent duplicate resource names. - Prevent duplicate published resource Id definitions. - Prevent duplicate database trigger names.
- Added test coverage for table script; - Added test coverage for new duplicate prevention. - Updated test script from nose to pytest.
- Added test requirements file.
- More setup and dependencies.
- More setup and dependencies.
- Docker image dependencies.
- Docker solr image target.
- Updated expected output. - Removed unnecessary `change_config`s.
- Added change log files.
wardi
reviewed
Jun 14, 2024
- Move expected dicts to class level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wardi really the only changes are in the
plugins.pyscript. All of the rest are test coverage stuff. Figured it would be good to add some more test coverage in here, independent of our whole app stack.