Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added radio identifier to Signal Pdu (DIS 7) #111

Merged

Conversation

adamwrobinson5
Copy link

No description provided.

@adamwrobinson5
Copy link
Author

@leif81 @brutzman Here's a PR for Issue #110

@leif81
Copy link
Member

leif81 commented May 14, 2023

Thank-you @adamwrobinson5 do you have a sample dis 7 signal and transmitter pdu, from another system, that could be used to add a unit test to help verify the change?

@adamwrobinson5
Copy link
Author

I'm sorry but because of the nature of my work, I can't provide any sample PDUs received from other systems. I have attached a picture from a document called DIS v6-v7 that I found in the SISO Digital Library. The image shows the Radio Reference ID and Radio Number which were missing from the Signal PDU prior to my fix.

Dis6vDis7

@leif81
Copy link
Member

leif81 commented May 16, 2023

Ok thank-you @adamwrobinson5, I understand, it's not the first time I've received a similar response, but I ask just in case!

The change looks good to me.

@leif81 leif81 merged commit daaff91 into open-dis:master May 16, 2023
@leif81 leif81 linked an issue May 16, 2023 that may be closed by this pull request
@adamwrobinson5
Copy link
Author

Awesome, thanks @leif81. Any idea when this change will be available on maven central?

@leif81
Copy link
Member

leif81 commented May 20, 2023

@adamwrobinson5 probably in the next week.

If you're in a rush take a look at the readme in the root of the project regarding using jitpack maven repository to try unreleased builds.

@leif81 leif81 changed the title added radio identifier to signal pdu Added radio identifier to DIS 7 Signal Pdu Jun 19, 2023
@leif81 leif81 changed the title Added radio identifier to DIS 7 Signal Pdu Added radio identifier to Signal Pdu (DIS 7) Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dis7 Signal PDU Missing Radio Identifier
3 participants