Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal Pdu fixes for encoding scheme and radio reference id (DIS 7) #129

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Signal Pdu fixes for encoding scheme and radio reference id (DIS 7) #129

merged 1 commit into from
Feb 22, 2024

Conversation

fo-ifad
Copy link
Contributor

@fo-ifad fo-ifad commented Feb 22, 2024

The fixes that has been made:

  1. according to IEEE Std 1278.1-2012 section 7.7.3, "d)", the Encoding Scheme record is a 16 bit record where bits 0-13 is one sub field and bits 14-15 are another sub field. Method that access these fields have been added to Signal Pdu.
  2. the "d)" section describes the Radio Reference ID record, and this does not contain Radio Number, and therefore this has been moved to Signal Pdu as described in standard.
  3. Unit test of Signal Pdu has been added

@fo-ifad
added methods to access fields of encoding Scheme record and moved ra…
81dd2c2 
…dio number to a more logical location according to the DIS7 standard and added unit test
@leif81 leif81 merged commit c109654 into open-dis:master Feb 22, 2024
@leif81
Copy link
Member

leif81 commented Feb 22, 2024

Great @fo-ifad 👍

@leif81 leif81 changed the title DIS 7 Signal Pdu Fixes Signal Pdu Fixes (DIS 7) Feb 23, 2024
@leif81 leif81 changed the title Signal Pdu Fixes (DIS 7) Signal Pdu fixes for encoding scheme and radio reference id (DIS 7) Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fo-ifad @leif81