Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix size and type of beamDataLength in AcousticBeamData (DIS 6) #142

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Fix size and type of beamDataLength in AcousticBeamData (DIS 6) #142

merged 3 commits into from
Apr 18, 2024

Conversation

Eihof
Copy link
Contributor

@Eihof Eihof commented Apr 12, 2024

isssue #141 bugfix.

@leif81 leif81 linked an issue Apr 12, 2024 that may be closed by this pull request
Wrong size/type of beamDataLength attribute in the AcousticBeamData class (DIS 6 and DIS 7) #141
Closed
@leif81
Copy link
Member

leif81 commented Apr 12, 2024

@Eihof These other sample PDUs in the unit test were captured with WireShark and exported in raw format.

Would you be able to do that? It would help confirm the change and add to the existing units test suites.

@Eihof
Copy link
Contributor Author

Eihof commented Apr 15, 2024

Yes, I'm able to export the UA Pdu to a raw file and write a unit test.

@Eihof
Copy link
Contributor Author

Eihof commented Apr 16, 2024

I am finished now.
DIS 7 Version of AcousticBeam class has the same problem. Unit test works in this case because there is no AcousticBeam data inside the raw file. I can also correct the class for DIS 7. Unfortunately I don't have any UA pdu data at the moment to extend the existing unit test. Once I have one I will also add it to the unit test later.
image

@Eihof Eihof mentioned this pull request Apr 17, 2024
Merged
@leif81
Copy link
Member

leif81 commented Apr 18, 2024

Looks great @Eihof

@leif81 leif81 merged commit 2eb4023 into open-dis:master Apr 18, 2024
@Eihof Eihof deleted the ua-beam-data-fix branch April 18, 2024 07:05
@leif81 leif81 changed the title Update AcousticBeamData.java Update AcousticBeamData (DIS 6) Jun 15, 2024
@leif81 leif81 changed the title Update AcousticBeamData (DIS 6) Fix size and type of beamDataLength in AcousticBeamData (DIS 6) Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong size/type of beamDataLength attribute in the AcousticBeamData class (DIS 6 and DIS 7)
2 participants
@Eihof @leif81