Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate attributes from SimulationManagementFamilyPdu (DIS 7) #27

Merged
merged 2 commits into from
Sep 21, 2016
Merged

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Sep 20, 2016

Remove the duplicate originating/receiving IDs as they are already part of SimulationManagementFamilyPdu

@leif81
Copy link
Member

leif81 commented Sep 20, 2016

Maybe those duplicate fields should be removed from all pdu's that inherit from SimulationManagementFamilyPdu?

e.g. CreateEntityPdu, RemoveEntityPdu, StopFreezePdu, AcknowledgePdu, ActionRequestPdu, ActionResponsePdu, should have it removed to.

Copy link
Collaborator

@mcgredonps mcgredonps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that error rippled through all the SimulationManagment family PDUs--it's in the SimulationManagementFamilyPdu class, and everything that inherits from that also has those fields incorrectly repeated.

@mcgredonps
Copy link
Collaborator

There's a SimulationManagementHeader object defined in the standard, which is just the regular PDU header plus the two identifier fields. It's defined earlier in the XML file. I don't think it's worthwhile to reuse that here, since it would make for a special case in the inheritance chain. Better to just remove the duplicate fields in the subclasses.

Remove the duplicate originating/receiving IDs
as they are already part of SimulationManagementFamilyPdu
@tzneal tzneal changed the title Fix duplicate attributes in StartResumePdu Fix duplicate attributes from SimulationManagementFamilyPdu Sep 20, 2016
@tzneal
Copy link
Contributor Author

tzneal commented Sep 21, 2016

I cleaned up the other sim family PDUs and also removed a duplicate PDU that I noticed.

@leif81
Copy link
Member

leif81 commented Sep 21, 2016

Nice. Looks good to me.

@mcgredonps mcgredonps merged commit d8ea9d1 into open-dis:master Sep 21, 2016
@leif81 leif81 changed the title Fix duplicate attributes from SimulationManagementFamilyPdu Fix duplicate attributes from SimulationManagementFamilyPdu (DIS 7) Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants