Pdu factory create pdu #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented additional pduTypeEnum's and combined createPdu(ByteBuffer) and createPdu(byte[]) versions (byte[] version is a wrapper over the ByteBuffer versions). Some pduTypeEnum's still need to be implemented, as they are not in the current DIS7.xml file.
|
I like it a lot. Love refactors like this that DRY code up. |
|
Btw for github cross ref purposes, once merged this will fix #32 . |
|
Looks good. |
mcgredonps
reviewed
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented additional pduTypeEnum's and combined createPdu(ByteBuffer)
and createPdu(byte[]) versions (byte[] version is a wrapper over the
ByteBuffer versions). Some pduTypeEnum's still need to be implemented,
as they are not in the current DIS7.xml file.