Add BasicHaveQuickMpRecord class #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utility class for working with HAVE QUICK modulation parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utility class for working with HAVE QUICK modulation parameters.
See the TransmitterPduTest unit test for an example of how I think this should be used.
I put this class into the
disutilpackage because the Basic HAVE QUICK MP record is not part of the DIS 6 standard, so I didn't want that to be confused. This record is how ASTi (and other DIS radios?) pack the HAVE QUICK data into the modulation parameters of a DIS 6 Transmitter PDU. I think this same spec made it's way into the DIS 7 standard as the "basic" option for representing HAVE QUICK. So the class could presumably be re-used with a DIS 7 Transmitter PDU, but I haven't tried, I don't have a use for that right now.