Add java 9+ support #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around an issue with java 9+ automatic module naming in particular when using open-dis artifacts from jitpack. It doesn't seem to like the sha1 in the name. Unlike creating a module-info.java file, this change retains compatibility with Java 6-8.
The dash breaks the naming rules.
|
I'm not sure about this one yet, so sticking the WIP (Work In Progress) flag on it while I mull it over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around an issue with java 9+ automatic module naming in particular when using open-dis artifacts from jitpack. It doesn't seem to like the sha1 in the name. Unlike creating a module-info.java file, this change retains compatibility with Java 6-8.