Removed DIS 6 & 7 length fields, replacing uses with dynamic getMarshalledSize() #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 12, 2020 10:07
…cating the getter and setter. Setter now does nothing, getter delegates to getMarshalledSize(). All uses of the field were replaced. Tested with EntityState and Acknowledge PDU types.
…ecating the getter and setter. Setter now does nothing, getter delegates to getMarshalledSize(). All uses of the field were replaced. Tested with EntityState and Acknowledge PDU types.
|
Thank-you @Updownquark ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in the commits, the length fields for both PDU superclasses are removed, the getter and setter deprecated, and uses replaced correctly.
I tested this locally using EntityState and Acknowledge PDU types for DIS 6 and 7 with no errors.