Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hashCode() #79

Merged
merged 2 commits into from
Feb 27, 2021
Merged

Added hashCode() #79

merged 2 commits into from
Feb 27, 2021

Conversation

lcowan94
Copy link

Added hasCode() to EntityID

@leif81
Copy link
Member

leif81 commented Feb 23, 2021

Thanks @lcowan94

I see the DIS6 EntityID class has a hashCode method, I wasn't familar with it until I went looking for it just now. I see it's a bit different and has a comment about why it was a certain way. Can you take a look. I wonder if we shouldn't copy the same for the DIS7 EntityID. Does it matter to you which implementation of hashCode we use here?

@lcowan94
Copy link
Author

I've added some tests for the equals and hashCode methods

@leif81 leif81 merged commit e653e7c into open-dis:master Feb 27, 2021
@leif81
Copy link
Member

leif81 commented Feb 27, 2021

Thank-you @lcowan94 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants