Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding export of dis.StringConversion for external use #1

Merged
merged 1 commit into from
Feb 7, 2018

Conversation

saylesc
Copy link

@saylesc saylesc commented Feb 1, 2018

Using dis.StringConversion methods in a nodejs environment caused an error without the exports statement.

Please let me know if you have other suggestions or feedback on this. Thanks

Copy link
Collaborator

@mcgredonps mcgredonps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, helpful to have other people spot my errors. (And my network was down for the weekend.)

It's helpful to correct the error in the source code, in this case at https://github.com/open-dis/open-dis-javascript/tree/master/javascript/disSupporting. Those files plus the generated js files get smashed together to make one big file. In this case the easiest approach is probably to just change the code there, plus include the original changes you already did. That should be pretty a rare occurance.

@mcgredonps
Copy link
Collaborator

Cose enough, fix the individual file as well

@mcgredonps mcgredonps merged commit 7386688 into open-dis:master Feb 7, 2018
@saylesc
Copy link
Author

saylesc commented Feb 8, 2018

Awesome. Sorry I was traveling and just saw this. Very much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants