-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include AppStream metainfo.xml #1258
Conversation
Can you add hint what it does resolve and how it is used. Does it need to be installed somewhere? |
… folder This matches the XDG spec for .desktop files: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
This brings the package more in line with the freedesktop XDG spec. The metainfo.xml file gets installed to /usr/share/metainfo, which allows the application to show up in places like Gnome software or KDE Discover, and properly shows the description, icon, screenshots, links to the repo, and changelog. I believe this will also allow users to uninstall the application using eg. gnome-software. The change to reverse-DNS naming for the .desktop file is also in line with the freedesktop spec. |
The most important change would be for distros that package digidoc. I actually had no idea that Fedora packages it, because without the metainfo it doesn't show up in gnome-software, which is fairly unusual for GUI software. It's been in dnf the whole time, but it never occurred to me to check! |
Can you please rebase latest master to fix windows builds. |
I found a good screenshot hosted on id.ee that I think it is nicely representative of the application. |
Do you have some idea when the next release would be, and might it be possible to get a version number bump with just the changes from this MR included? Again, for distros that package digidoc this would be a huge help, as it would allow the application to show up in graphical package managers / "software centers". |
Signed-off-by: Simon Dalzell simon@oddlypresent.com