Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download resources when they do not exist in source folder #1277

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Download resources when they do not exist in source folder #1277

merged 1 commit into from
Jul 31, 2024

Conversation

metsma
Copy link
Contributor

@metsma metsma commented Jul 1, 2024

IB-8136, Fixes #1274

Signed-off-by: Raul Metsma raul@metsma.ee

@metsma metsma mentioned this pull request Jul 1, 2024
Closed
@LecrisUT
Copy link

LecrisUT commented Jul 1, 2024 •
edited
Loading

Only 1 issue, CMAKE_CURRENT_SOURCE_DIR in common does not point to the SOURCE_DIR of the top-level project (it is pointing to /common instead of /). It is possible to work with that, but is that the intended design? I.e. if common is meant to only be used via add_subdirectory, than CMAKE_SOURCE_DIR would be a better alternative.

Similar with TSL.qrc, should be in / or /client?

@metsma metsma force-pushed the res branch 2 times, most recently from 56a8982 to fa6eac9 Compare July 24, 2024 10:48
@metsma
Download resources when they do not exist in source folder
63830f4 
IB-8136, Fixes open-eid#1274

Signed-off-by: Raul Metsma <raul@metsma.ee>
@metsma
Copy link
Contributor Author

metsma commented Jul 30, 2024

Only 1 issue, CMAKE_CURRENT_SOURCE_DIR in common does not point to the SOURCE_DIR of the top-level project (it is pointing to /common instead of /). It is possible to work with that, but is that the intended design? I.e. if common is meant to only be used via add_subdirectory, than CMAKE_SOURCE_DIR would be a better alternative.

Similar with TSL.qrc, should be in / or /client?

Updated the instructions
https://github.com/open-eid/DigiDoc4-Client/wiki/DeveloperTips#building-in-sandboxed-environment

@kristelmerilain kristelmerilain merged commit a857685 into open-eid:master Jul 31, 2024
12 checks passed
@metsma metsma deleted the res branch July 31, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LecrisUT LecrisUT LecrisUT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug in DeveloperTips wiki page
3 participants
@metsma @LecrisUT @kristelmerilain