Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take OCSP URL from AIA extension #138

Merged
merged 1 commit into from
Aug 21, 2017
Merged

Take OCSP URL from AIA extension #138

merged 1 commit into from
Aug 21, 2017

Conversation

metsma
Copy link
Contributor

@metsma metsma commented Jul 21, 2017

IB-4174

Signed-off-by: Raul Metsma raul@metsma.ee

@metsma
Take OCSP URL from AIA extension
a35b6c9 
IB-4174

Signed-off-by: Raul Metsma <raul@metsma.ee>
@tynisr tynisr requested a review from uudisaru August 18, 2017 09:50
uudisaru
uudisaru approved these changes Aug 19, 2017
View reviewed changes
Copy link
Contributor

@uudisaru uudisaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted, but for next time I suggest to include non-related changes (variable scope and error handling in OCSP::createRequest()) in a separate commit.
Otherwise it is hard to understand what is related to the described changes and what is code refactoring.

@uudisaru uudisaru merged commit 7053243 into open-eid:master Aug 21, 2017
@metsma metsma deleted the ocsp branch August 21, 2017 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uudisaru uudisaru uudisaru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metsma @uudisaru