Fedora build #441
Merged
Fedora build #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All work and the RPM installs fine. |
metsma
reviewed
Nov 9, 2021
metsma
requested changes
Nov 11, 2021
|
If you plan build digidoc4-client you probably need also save the artifacts. If not we can merge |
metsma
approved these changes
Nov 18, 2021
|
There are some issues with the artefacts |
metsma
reviewed
Nov 18, 2021
.github/workflows/build.yml
Outdated
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: rpms | ||
| path: libdigidocpp*.rpm |
There was a problem hiding this comment.
Build on Fedora to fedora:33
No files were found with the provided path: libdigidocpp*.rpm. No artifacts will be uploaded.
There was a problem hiding this comment.
path: build/libdigidocpp*.rpm ??
|
Lets see if this also adds config files to correct place |
metsma
requested changes
Nov 21, 2021
Co-authored-by: Raul Metsma <raul@metsma.ee>
Co-authored-by: Raul Metsma <raul@metsma.ee>
metsma
approved these changes
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #410 with rebase and conflict resolved