Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

更新依赖 sirupsen/logrus #818

Closed
shaneing opened this issue Oct 15, 2019 · 1 comment · Fixed by #824
Closed

更新依赖 sirupsen/logrus #818

shaneing opened this issue Oct 15, 2019 · 1 comment · Fixed by #824

Comments

@shaneing
Copy link
Contributor

shaneing commented Oct 15, 2019 •
edited
Loading

早在 2017 年，logrus 的作者更改了 github 的用户名以至于造成灾难，具体可看：

Rename back to Sirupsen/logrus

如何更新？

find modules/ -name '*.go' | xargs gofmt -r '"github.com/Sirupsen/logrus" -> "github.com/sirupsen/logrus"' -w
govendor fetch github.com/masato25/yaag/gin
govendor remove github.com/Sirupsen/logrus
@laiwei
Copy link
Member

laiwei commented Oct 15, 2019

欢迎提交PR :) @shaneing

shaneing pushed a commit to shaneing/falcon-plus that referenced this issue Oct 28, 2019
chore: update dependency sirupsen/logrus@v1.0.6
17dce73 
The logrus need indirect dependencies as follows:

-
`golang.org/x/crypto/ssh/terminal`
- `golang.org/x/sys/unix`

So,
resolve them.

The next to update `github.com/masato25/yaag/gin` due to
the use `sirupsen/logrus`.

Why is `v1.0.6`? Just for compatibility with
go1.6.

Closes open-falcon#818
@shaneing shaneing mentioned this issue Oct 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update dependency sirupsen/logrus@v1.0.6 shaneing/falcon-plus
2 participants
@laiwei @shaneing